Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra containerized nccl tests #298

Closed
wants to merge 2 commits into from
Closed

Extra containerized nccl tests #298

wants to merge 2 commits into from

Conversation

verdimrc
Copy link
Contributor

@verdimrc verdimrc commented May 3, 2024

Issue #, if available: N/A

Description of changes: sample .sbatch scripts to run nccl tests under containers. Two variants: native implementation, and a pure pytorch-based (that some of our customers have been using for benchmarking).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

## Sample command to download:
##
## curl -LO https://raw.githubusercontent.com/stas00/ml-engineering/master/network/benchmarks/all_reduce_bench.py
srun -l --wait 300 "${ARGS[@]}" torchrun "${TORCHRUN_ARGS[@]}" ${FSX_MOUNT}/all_reduce_bench.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional to let user to pull this file from a separate repo.

Copy link
Contributor

@mhuguesaws mhuguesaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

@verdimrc
Copy link
Contributor Author

verdimrc commented May 7, 2024

To rebase once #314 merged.

@sean-smith sean-smith closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants