fix model builder limited container support for endpoint mode. #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… containers other than TGI and DJL
makungaj1
changed the title
qiyunz
reviewed
May 15, 2024
| if "djl-inference" in image_uri: | ||
| logger.info("Building for DJL JumpStart Model ID...") | ||
| self.model_server = ModelServer.DJL_SERVING | ||
| if "djl-inference" in self.pysdk_model.image_uri: |
There was a problem hiding this comment.
can we add huggingface-pytorch-inference in the image URI matching logic and map ti model server of MMS.
There was a problem hiding this comment.
Let's add it next as we may need to add tune capability for it.
There was a problem hiding this comment.
no tune function needed for the HF container, the goal is to make it work with local container mode first.
qiyunz
reviewed
May 15, 2024
| self.pysdk_model.tune = self.tune_for_tgi_jumpstart | ||
| elif "huggingface-pytorch-inference:" in self.pysdk_model.image_uri: | ||
| logger.info("Building for MMS JumpStart Model ID...") | ||
| self.model_server = ModelServer.TGI |
There was a problem hiding this comment.
why mapping to TGI? should be MMS right?
qiyunz
approved these changes
May 15, 2024
samruds
approved these changes
May 16, 2024
mufaddal-rohawala
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… containers other than TGI and DJL
Issue #, if available:
Description of changes:
Fix: ModelBuilder limited container support for endpoint mode.
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.