Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Creature): Isfar gossip options #18688

Closed
wants to merge 1 commit into from

Conversation

bauxa
Copy link
Contributor

@bauxa bauxa commented Apr 8, 2024

Changes Proposed:

This PR proposes changes to:

  • Database (SAI, creatures, etc).

Removed dialogue option that shouldn't be here.

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)

Tests Performed:

This PR has been:

  • Tested in-game by the author.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  1. Go to Isfar
  2. Click on the dialogue option you want

Known Issues and TODO List:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Apr 8, 2024
@pangolp
Copy link
Contributor

pangolp commented May 2, 2024

Although, the result is the same. Perhaps the best thing would be to delete and add the records. I left the code above.

@bauxa bauxa closed this by deleting the head repository May 22, 2024
@pangolp
Copy link
Contributor

pangolp commented May 22, 2024

Why did I close the pull request? I had sent him a suggestion of a change. Sometimes, instead of making a UPDATE, it is convenient to delete and reinsert, in case the script, is run individually, without the rest of the scripts. It was a minor change, but I think it was valid. Unless another person has repaired it in another commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isfar incorrect dialogue options NPC Isfar's conversation tree does not work.
2 participants