Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Scripts/Battlegrounds/AlteracValley): Adding missing Tower Archers #18746

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Knindzagxg
Copy link
Member

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)

Tests Performed:

This PR has been:

  • Tested in-game by the author.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  1. Log into game and .debug bg.
  2. Check spawns on the Towers and Archers AI.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@Knindzagxg Knindzagxg requested a review from Nyeriah April 14, 2024 14:19
@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Apr 14, 2024
@icedcolor
Copy link

There are no NPC guards in Horde's cave.

@sudlud
Copy link
Member

sudlud commented Apr 20, 2024

There are no NPC guards in Horde's cave.

Is this an issue of this PR or just a general issue of AV?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Ready to be Reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants