Added a way to support custom hostname to emit metrics #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshardool
reviewed
Dec 10, 2021
| @@ -117,14 +117,19 @@ public Timer addTimer(final String name) { | |||
| public synchronized void startReporting(final String reporterName, final Props props) { | |||
| final String metricsReporterClassName = props.get(CUSTOM_METRICS_REPORTER_CLASS_NAME); | |||
| final String metricsServerURL = props.get(METRICS_SERVER_URL); | |||
| final String customHostNameToEmitMetrics = props.get(CUSTOM_METRICS_HOSTNAME); | |||
There was a problem hiding this comment.
What's the behavior when the property CUSTOM_METRICS_HOSTNAME is not set ?
Ideally we would wan't the default behavior to stay unchanged, if that's the case please mention that in a comment. Please let me know if you think otherwise.
There was a problem hiding this comment.
this property is an optional one. If we don't set it, the default behaviour stays as it is. Let me update the PR description too. Thanks for taking a look!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will enable us to pass custom hostname (usually a fixed one) to emit and refer metrics in containerized Azkaban web server. If the custom metric property is not set, it fallbacks to the default behaviour (ie we consider the hostname of the machine).
Tested this change in conjunction with AmfReporter library update, and observed that metrics got emitted.