make job name optional #4005
make job name optional #4005
Conversation
|
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
| "github.com/bacalhau-project/bacalhau/pkg/test/mock" | ||
| ) | ||
|
|
||
| type JobTestSuite struct { |
There was a problem hiding this comment.
We should be explicit with the job type we set since there is different behavior regarding jobIDs dependent on its type:
Line 295 in a78a88d
There was a problem hiding this comment.
As we are both working on very different timezones, my recommendation is to have bias for action and not block PRs for things not related to the PR itself. Feel free to add comments and I'll make sure I'll address what I can or open follow-up issues to track the ones that I can't, but give approval if there are no concerns with the main scope of the PR.
Added tests in d9191d6
pkg/models/job_test.go
Outdated
| // Ensure nested objects are deeply copied | ||
| for i, task := range job.Tasks { | ||
| suite.NotSame(task, cpy.Tasks[i], "The tasks in the job and its copy should not be the same instance") | ||
| } |
There was a problem hiding this comment.
since we only support one task right now we should use the Task() method here present on the job and its copy.
There was a problem hiding this comment.
we should all tasks are equal in copy, otherwise we will only be verifying the first tasks are the same, and won't catch if copy is appending more tasks for some reason.
I've added a dedicated test for Task() in d9191d6
|
|
||
| func (suite *JobTestSuite) TestNamespacedID() { | ||
| job := mock.Job() | ||
| nsID := job.NamespacedID() |
There was a problem hiding this comment.
what is the purpose of NamespacedID?
There was a problem hiding this comment.
globally unique job id across namespaces. When we allow users to set their own job IDs, they only need to be unique within their own namespace and not globally
Use the auto-generated job id as the job name value if name was not provided