Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added get to job type command #4008

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

added get to job type command #4008

wants to merge 4 commits into from

Conversation

leostelon
Copy link

@leostelon leostelon commented May 17, 2024 •
edited

PR contains

  1. Add bacalhau job get to download results. Move bacalhau get to bacalhau job get #3971
  2. Removed unused parameters from legacy get_test.go.
  3. Modified description to download jobs using the "job get" command.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 17, 2024 •
edited

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

wdbaruni
wdbaruni requested changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@wdbaruni wdbaruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Leo for your awesome contribution. Just some minor comments

cmd/cli/job/get.go
Comment on lines +43 to +44
func NewGetCmd() *cobra.Command {
OG := NewGetOptions()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be great is if we can have the existing get command call this new implementation to avoid duplicating code. Similar to how we are handling bacalhau logs and bacalhau job logs https://github.com/bacalhau-project/bacalhau/blob/main/cmd/cli/logs/logs.go

I would also move the tests to this package as our goal is to eventually deprecate bacalhau get and only keep bacalhau job get

cmd/util/printer/print_legacy.go Outdated
Comment on lines 132 to 136
cmd.Printf("\nTo download the results, execute:\n\t"+os.Args[0]+" job get %s\n", j.ID())
}

if !quiet {
cmd.Printf("\nTo get more details about the run, execute:\n\t"+os.Args[0]+" describe %s\n", j.ID())
cmd.Printf("\nTo get more details about the run, execute:\n\t"+os.Args[0]+" job describe %s\n", j.ID())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still want the legacy commands to refer to the legacy get and describe commands as bacalhau describe's output is different than bacalhau job describe

@leostelon
Copy link
Author

Can you check now, I have removed the duplicate code.

@frrist frrist linked an issue Jun 5, 2024 that may be closed by this pull request
Move bacalhau logs to bacalhau job logs #4048
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdbaruni wdbaruni wdbaruni requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move bacalhau logs to bacalhau job logs
3 participants
@leostelon @wdbaruni @aronchick