Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updating the redaction message to something a little less dramatic #24795

Merged
merged 2 commits into from
May 20, 2024

Conversation

benjdlambert
Copy link
Member

Little pet peeve, but [REDACTED] is something i've been wanting to get rid of for a while. Thinking we take some inspiration from what GitHub actions does and just replace with *** instead?

Signed-off-by: blam <ben@blam.sh>

Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
@benjdlambert benjdlambert requested review from a team as code owners May 15, 2024 15:46
@github-actions github-actions bot added the area:scaffolder Everything and all things related to the scaffolder project area label May 15, 2024
@backstage-goalie
Copy link
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/backend-app-api packages/backend-app-api patch v0.7.3
@backstage/plugin-scaffolder-backend plugins/scaffolder-backend patch v1.22.6

Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks [REDACTED] to me

@benjdlambert benjdlambert merged commit 4e72e02 into master May 20, 2024
28 checks passed
@benjdlambert benjdlambert deleted the blam/redact-to-stars branch May 20, 2024 08:15
Copy link
Contributor

Thank you for contributing to Backstage! The changes in this pull request will be part of the 1.28.0 release, scheduled for Tue, 18 Jun 2024.

Copy link
Contributor

Uffizzi Cluster pr-24795 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:scaffolder Everything and all things related to the scaffolder project area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants