Implementation of edge insets for StepperView for positioning #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 20, 2021 12:25
rcole34
reviewed
May 20, 2021
| struct StepperEdgeInsetsKey: EnvironmentKey { | ||
| /// provide default values for Stepper Edge Insets | ||
| static var defaultValue: EdgeInsets = | ||
| EdgeInsets(top: Utils.standardSpacing, leading: Utils.standardSpacing, bottom: Utils.standardSpacing, trailing: Utils.standardSpacing) |
There was a problem hiding this comment.
This may slightly change the default spacing, as if you just add .padding() it uses the system default (varies based on device type and other conditions). If we made stepperEdgeInsets be optional EdgeInsets? with a default value of nil then passing .padding(nil) will retain the current behavior.
There was a problem hiding this comment.
I am evaluating this default padding behaviour across all the watchOS, iOS and test it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of EdgeInsets for positioning the Stepper View according to the desired choice.
Type of change
How Has This Been Tested
Please let us know if you have tested your PR and if we need to reproduce the issues. Also, please let us know if we need any relevant information for running the tests.
Test Configuration
Checklist:
For checklist items not applicable, mention NA in front of it with some comment if applicable.