theme: filterable dynamic options. #9570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some conflicts in this PR. Please fix the PR conflicts. |
suraj-webkul
force-pushed
the
theme-filter-options
branch
2 times, most recently
from
82724ad
to
4e1c928
Compare
|
Resolved conflicts. |
devansh-webkul
requested changes
Apr 3, 2024
packages/Webkul/Admin/src/Resources/views/settings/themes/edit/product-carousel.blade.php
Outdated
Show resolved
Hide resolved
devansh-webkul
previously approved these changes
May 6, 2024
ashishkumar-webkul
added
QA Passed
|
Checked and Found that the filters are working fine, please check the video for reference. Video Filters.added.mp4 |
ashishkumar-webkul
added
Change Request
|
Need to fix the issue of static content view, page is not appearing properly. Please fix the issue. Video Static.mp4 |
|
Conflicts. |
suraj-webkul
added
the
Fix Proposed
ashishkumar-webkul
added
In Testing
|
Checked and found that the issue related to the static content pages in theme section and also the product crousal concern are added with filters, hence the issue has been fixed and working fine. Please check the video for reference. Video Static.mp4 |
ashishkumar-webkul
approved these changes
May 14, 2024
devansh-webkul
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.