Optimize address form layout to improve page length #9708
Conversation
ghermans
changed the title
| <x-shop::form.control-group.control type="text" name="company_name" :value="old('company_name')" | ||
| :label="trans('shop::app.customers.account.addresses.company-name')" | ||
| :placeholder="trans('shop::app.customers.account.addresses.company-name')" /> |
There was a problem hiding this comment.
Break attributes into multiple lines
| <x-shop::form.control-group.control type="text" name="vat_id" :value="old('vat_id')" | ||
| :label="trans('shop::app.customers.account.addresses.vat-id')" | ||
| :placeholder="trans('shop::app.customers.account.addresses.vat-id')" /> |
There was a problem hiding this comment.
Break attributes into multiple lines
| <x-shop::form.control-group.control type="text" name="postcode" | ||
| rules="{{ core()->isPostCodeRequired() ? 'required' : '' }}|numeric" :value="old('postcode')" |
There was a problem hiding this comment.
Break attributes into multiple lines
| rules="{{ core()->isCountryRequired() ? 'required' : '' }}" v-model="country" | ||
| aria-label="trans('shop::app.customers.account.addresses.country')" | ||
| :label="trans('shop::app.customers.account.addresses.country')"> |
There was a problem hiding this comment.
Break attributes into multiple lines
| <x-shop::form.control-group.control type="select" id="state" name="state" | ||
| rules="{{ core()->isStateRequired() ? 'required' : '' }}" v-model="state" | ||
| :label="trans('shop::app.customers.account.addresses.state')" | ||
| :placeholder="trans('shop::app.customers.account.addresses.state')"> |
There was a problem hiding this comment.
Break attributes into multiple lines
| </template> | ||
|
|
||
| <template v-else> | ||
| <x-shop::form.control-group.control type="text" name="state" :value="old('state')" |
There was a problem hiding this comment.
Break attributes into multiple lines
| <x-shop::form.control-group.control type="text" name="phone" rules="required|integer" :value="old('phone')" | ||
| :label="trans('shop::app.customers.account.addresses.phone')" | ||
| :placeholder="trans('shop::app.customers.account.addresses.phone')" /> |
There was a problem hiding this comment.
Break attributes into multiple lines
|
Hi @ghermans, Please break input field attributes into multiple lines in both the edit and create files. Please refer to other files for reference. |
|
@ghermans Any update? |
|
@devansh-webkul yes i will push the update during the night |
|
@devansh-webkul the required changes have been pushed |
|
Pen test keep failing on this PR, i'm closing this one since its not a high prio change |
Description
This pull request addresses the issue of long page length by rearranging the positions of form control groups. By doing so, we aim to improve the overall user experience and make the page more manageable.
Changes Made
Screenshots
Add address
Edit form
How To Test This?