Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed select type attribute view for mobile #9741

Merged
merged 7 commits into from May 14, 2024

Conversation

shivendra-webkul
Copy link
Collaborator

@shivendra-webkul shivendra-webkul commented Apr 30, 2024

Issue Reference

Fixed select type attribute view for mobile.
Fixed input box sifting issue in invoice and shipment drawer.

@ashishkumar-webkul
Copy link
Collaborator

@shivendra-webkul

Please check this PR again as there is a conflicts. Please resolve it so that I can further test.

@ashishkumar-webkul ashishkumar-webkul added the Conflicts When conflicts present in pull request. label May 8, 2024
@shivendra-webkul shivendra-webkul removed the Conflicts When conflicts present in pull request. label May 9, 2024
@ashishkumar-webkul ashishkumar-webkul added the Conflicts When conflicts present in pull request. label May 13, 2024
@shivendra-webkul shivendra-webkul removed the Conflicts When conflicts present in pull request. label May 13, 2024
@ashishkumar-webkul ashishkumar-webkul added the In Testing When PR in testing. label May 13, 2024
@ashishkumar-webkul
Copy link
Collaborator

Checked and Found that the issues has been fixed and working fine, please check the video for reference.

Screenshots

https://prnt.sc/VOBYjjaHV2cE

https://prnt.sc/Hrjdicuu-FG8

Video

Drawer.mp4

@ashishkumar-webkul ashishkumar-webkul added QA Passed When QA pass the pull request. and removed In Testing When PR in testing. labels May 13, 2024
devansh-webkul
devansh-webkul previously approved these changes May 14, 2024
@ashishkumar-webkul ashishkumar-webkul added In Testing When PR in testing. and removed QA Passed When QA pass the pull request. labels May 14, 2024
@ashishkumar-webkul
Copy link
Collaborator

Checked and found that the size of dropdown select type issue has been fixed.

Video

Size.issue.mp4

@ashishkumar-webkul ashishkumar-webkul added QA Passed When QA pass the pull request. and removed In Testing When PR in testing. labels May 14, 2024
@jitendra-webkul jitendra-webkul merged commit 4bb427c into bagisto:master May 14, 2024
4 checks passed
@shivendra-webkul shivendra-webkul deleted the mobile-view branch May 14, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed When QA pass the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants