Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Social Share For mobile view. #9773

Merged
merged 3 commits into from May 14, 2024
Merged

Fix Social Share For mobile view. #9773

merged 3 commits into from May 14, 2024

Conversation

amit-webkul
Copy link
Collaborator

Issue Reference

#9772

@amit-webkul amit-webkul mentioned this pull request May 9, 2024
Closed
1 task
@ashishkumar-webkul ashishkumar-webkul added In Testing When PR in testing. Change Request if need any changes on PR and removed In Testing When PR in testing. labels May 13, 2024
@ashishkumar-webkul
Copy link
Collaborator

Checked and Found that warning pop-up is appearing when I am checking the PR, It is not compatible with browser. Please check the video for reference.

Video

Browser.mp4

@amit-webkul
Copy link
Collaborator Author

@ashishkumar-webkul ｓiｒ

I have checked in mobile phone the social share is working fine please find the below attachment.

RPReplay_Final1715662307.mp4

@amit-webkul amit-webkul added Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. and removed Change Request if need any changes on PR labels May 14, 2024
@devansh-webkul devansh-webkul removed the Fix Proposed A issue that has a PR related to it that provides a possible resolution but stil needs to be merged. label May 14, 2024
@ashishkumar-webkul
Copy link
Collaborator

Checked and found that the social share is working, please check the video for reference.

Video

Social.1.mp4

@ashishkumar-webkul ashishkumar-webkul added the QA Passed When QA pass the pull request. label May 14, 2024
@jitendra-webkul jitendra-webkul merged commit a6bc4f2 into bagisto:master May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitendra-webkul jitendra-webkul jitendra-webkul approved these changes

@devansh-webkul devansh-webkul devansh-webkul approved these changes

Assignees

@ashishkumar-webkul ashishkumar-webkul

Labels
QA Passed When QA pass the pull request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amit-webkul @ashishkumar-webkul @jitendra-webkul @devansh-webkul