Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9719 fixed #9776

Merged

Conversation

jitendra-webkul
Copy link
Member

Issue Reference

Issue #9719 fixed

@ashishkumar-webkul ashishkumar-webkul added the In Testing When PR in testing. label May 10, 2024
Copy link
Collaborator

@ashishkumar-webkul ashishkumar-webkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and Found 2 issues.

  1. Image Swatch -> Images not appearing properly.
    Screenshot -> https://prnt.sc/f2uSPPItElKF, https://prnt.sc/p8WxQDdgGaf3

  2. After switching colour, Size dropdown box appears empty, It should show "Please select the option."

Video

Please.select.mp4

@ashishkumar-webkul ashishkumar-webkul added Change Request if need any changes on PR and removed In Testing When PR in testing. labels May 13, 2024
@ashishkumar-webkul ashishkumar-webkul added the In Testing When PR in testing. label May 13, 2024
@jitendra-webkul jitendra-webkul removed the Change Request if need any changes on PR label May 14, 2024
Copy link
Collaborator

@ashishkumar-webkul ashishkumar-webkul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and Found that the issue has been fixed, Price are appearing correct according to the Varient and also when we switch the option we need to again select the Dropdown option. Hence I have checked the same in Arbic and English locale.

Please check the video for reference.

Video

Select.mp4

@ashishkumar-webkul ashishkumar-webkul added QA Passed When QA pass the pull request. and removed In Testing When PR in testing. labels May 14, 2024
@jitendra-webkul jitendra-webkul merged commit 66eb0d3 into bagisto:master May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Passed When QA pass the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants