Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minifix(GUI): fix formatting of ETA #3756

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

getsnoopy
Copy link

This commit fixes the formatting of the estimated time of arrival to use
the proper symbols as per the SI.

This commit fixes the formatting of the estimated time of arrival to use
the proper symbols as per the SI.
@ghost
Copy link

ghost commented May 2, 2022

An error occurred whilst building your landr site preview:

{
  "name": "JSONHTTPError",
  "status": 429,
  "json": {
    "code": 429,
    "message": "You have reached a limit for sites. Please contact support for further assistance."
  },
  "message": "Too Many Requests",
  "stack": "JSONHTTPError: Too Many Requests\n    at parseResponse (/usr/src/app/node_modules/netlify/src/methods/response.js:13:11)\n    at runMicrotasks (<anonymous>)\n    at processTicksAndRejections (internal/process/task_queues.js:95:5)\n    at async callMethod (/usr/src/app/node_modules/netlify/src/methods/index.js:33:26)\n    at async Object.exports.setupSite (/usr/src/app/lib/netlify.js:69:18)\n    at async Object.exports.run (/usr/src/app/lib/build-runner.js:161:7)\n    at async build (/usr/src/app/bot/index.js:132:19)\n    at async /usr/src/app/bot/index.js:210:25\n    at async Promise.all (index 0)\n    at async middleware (/usr/src/app/node_modules/@octokit/webhooks/dist-node/index.js:355:5)"
}

@getsnoopy getsnoopy changed the title Fix formatting of ETA minifix(GUI): fix formatting of ETA May 2, 2022
Copy link

@Robertschv Robertschv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

“m” is used for meter not minutes, “min” is the correct abbreviation of minutes, and the spaces are needed too.

@Robertschv
Copy link

@getsnoopy pull request needs rebase!

@getsnoopy
Copy link
Author

@Robertschv Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants