Add unsetProperty in hooks #1308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabsource
force-pushed
the
ignore_models_properties
branch
from
e5aafea
to
e63d191
Compare
|
Wouldn't be the point of the hooks that we don't add configs for every use-case on earth? Like: sure, let's add the hook method but not the config? |
Sure. Found it more convenient (less verbose) but indeed it's for a specific use case and may pollute the config file. |
gabsource
force-pushed
the
ignore_models_properties
branch
from
e63d191
to
cb49a1f
Compare
gabsource
changed the title
mfn
reviewed
May 3, 2022
| @@ -830,7 +837,7 @@ public function setMethod($name, $type = '', $arguments = [], $comment = '') | |||
|
|
|||
| public function unsetMethod($name) | |||
| { | |||
| unset($this->methods[strtolower($name)]); | |||
| unset($this->methods[$name]); | |||
There was a problem hiding this comment.
Not sure if we should change this…
It's from the initial implementation https://github.com/barryvdh/laravel-ide-helper/pull/1198/files#diff-2df8ee218526540f71334c651990edfbfe5345cc53a521b0259c874ff24abd9aR766
ping @jenga201 if you remember why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR add options to ignore some properties :
It is useful to prevent PhpDoc generation for properties that should be used via a model cast only through a custom class.
Type of change
Checklist
composer fix-style