Refactor, fix bw POW, fix get_index, deprecated flamegraph, move matmul #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: benny-nottonson <bennynottonson@gmail.com>
Benny-Nottonson
requested review from
StijnWoestenborghs and
andresnowak
and removed request for
StijnWoestenborghs
Signed-off-by: benny-nottonson <bennynottonson@gmail.com>
Benny-Nottonson
changed the title
|
The most recent commit also fixes #85 by using epsilon for values at 0 (Common in other ML libraries) |
Signed-off-by: benny-nottonson <bennynottonson@gmail.com>
Signed-off-by: benny-nottonson <bennynottonson@gmail.com>
Benny-Nottonson
changed the title
Benny-Nottonson
changed the title
|
Fixed #88 with vectorization, ideally should be switched to a hashmap but I left as is for now. Also deprecated the flamegraph shell script since the builtin model profile is way more accuarate. |
Signed-off-by: benny-nottonson <bennynottonson@gmail.com>
Signed-off-by: benny-nottonson <bennynottonson@gmail.com>
Benny-Nottonson
changed the title
|
Also fixed #105 now |
|
I don't have any comments on this. This is all good for me |
StijnWoestenborghs
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to mostly the Graph API, some minor changes to tensorutils aswell. Nothing major but passing all tests and getting SLIGHT (5%) speedup on my machine. Could be placebo but its worth taking a look at, might have to do with list.reserve usage and avoiding append for single items.
This branch fixes #85, #88, and #105