-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire up oneversion
tool in java_tools
#22246
base: master
Are you sure you want to change the base?
Conversation
2a15505
to
1e8ff63
Compare
@bazel-io fork 7.2.0 |
To confirm, does this change take effect without a java_tools release? |
It includes some changes that only take effect with a new java_tools version, but users can just update |
I resolved the conflict. |
* Adds a prebuilt `one_version` tool as well as sources to `java_tools`. * Avoids passing `--whitelist` to `one_version` if no allowlist is configured in the toolchain, which isn't supported by the Bazel version of `oneversion` yet. * Documents the `one_version` flags. * Clean up tests not updated after recent rules_java releases.
@fmeum CI appears to be unhappy with this on Windows |
The error is:
It's not clear to me how this PR could cause this and it didn't occur before I rebased onto master. Will try to reproduce this locally. |
@fmeum Could you please take a look at the failing checks? |
@meteorcloudy Do you happen to have an idea what could be causing such an error? |
I have no idea.. but let me try if I can reproduce it locally |
I can only confirm the permission denied error is caused by running the It looks like something was still holding a file handle to java.dll after the test was done. I have no idea what exactly, but adding bazel/src/test/shell/bazel/bazel_java_test.sh Lines 90 to 92 in 25a9d53
|
I also noticed all those |
@meteorcloudy Thanks for digging into this, I added |
@satyanandak CI is green |
one_version
tool as well as sources tojava_tools
.--whitelist
toone_version
if no allowlist is configured in the toolchain as it isn't supported by the Bazel version ofoneversion
yet.one_version
flags.Work towards #1071