Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable header parsing test on macOS #22370

Closed
wants to merge 1 commit into from
Closed

Enable header parsing test on macOS #22370

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented May 14, 2024

No description provided.

@keith keith mentioned this pull request May 15, 2024
Closed
@keith keith force-pushed the ks/enable-header-parsing-test-on-macos branch from 5687943 to 00fd7da Compare May 17, 2024 16:59
@keith keith changed the title Test header parsing on macOS Enable header parsing test on macOS May 17, 2024
@keith keith force-pushed the ks/enable-header-parsing-test-on-macos branch from 00fd7da to 68c15be Compare May 21, 2024 17:19
@keith keith marked this pull request as ready for review May 21, 2024 17:19
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 21, 2024
@keith
Copy link
Member Author

keith commented May 21, 2024

need to wait for #22475

@iancha1992 iancha1992 added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label May 21, 2024
meteorcloudy
meteorcloudy approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 28, 2024
@keith
Copy link
Member Author

keith commented May 28, 2024 •
edited

#22475 still has to land before this one

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keith @meteorcloudy @iancha1992