BEP: Sets start_time on BuildStarted events from NoBuildEvent
#22376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When handling invocations we noticed some invocations still weren't setting `start_time` on `BuildStarted`. We specifically noticed this on build event streams from `query` invocations. After some spelunking I found `NoBuildEvent`, which didn't get updated with the rest of the codebase in e5c832a.
github-actions
bot
added
team-Configurability
Yannic
approved these changes
May 15, 2024
src/main/java/com/google/devtools/build/lib/analysis/NoBuildEvent.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Yannic <contact@yannic-bonenberger.com>
sgowroji
added
awaiting-user-response
|
Hi @iamricard Could you please sign the CLA? |
|
I have signed it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling invocations we noticed some invocations still weren't setting
start_timeonBuildStarted. We specifically noticed this on build event streams fromqueryinvocations. After some spelunking I foundNoBuildEvent, which didn't get updated with the rest of the codebase in e5c832a.cc @lfpino