Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Bazel with Bazel 7.2.0rc1 #22400

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 16, 2024

No description provided.

@fmeum fmeum force-pushed the bazel-7.2.0 branch 3 times, most recently from e191001 to bf97b89 Compare May 16, 2024 12:44
@fmeum
Copy link
Collaborator Author

fmeum commented May 16, 2024

@keertk @iancha1992 FYI, I prepared this PR to verify compatibility with the new lockfile format. Happy to finalize it when 7.2.0 lands.

@iancha1992
Copy link
Member

@keertk @iancha1992 FYI, I prepared this PR to verify compatibility with the new lockfile format. Happy to finalize it when 7.2.0 lands.

Just FYI, if you change the .bazelversion, I think you might need to update the lockfile on all four platforms.

@fmeum
Copy link
Collaborator Author

fmeum commented May 16, 2024

Thanks, I'm in the process of setting up a Windows VM for that. But I likely need to do it again after the actual release, so I'll wait for that.

@Wyverald
Copy link
Member

Thanks, I'm in the process of setting up a Windows VM for that. But I likely need to do it again after the actual release, so I'll wait for that.

I'd suggest you not to worry about it, and let us (me?) do the work when 7.2.0 is actually released :) I've done this multiple times now and have all four machine types on hand.

@Wyverald
Copy link
Member

or, actually, if we could get rules_python to declare certain module extensions of theirs to be reproducible, we might be able to just remove all traces of them from the lockfile.

@fmeum
Copy link
Collaborator Author

fmeum commented May 16, 2024

or, actually, if we could get rules_python to declare certain module extensions of theirs to be reproducible, we might be able to just remove all traces of them from the lockfile.

I looked into that today: Two of their extensions are trivially reproducible (bazelbuild/rules_python#1892), but the pip extension is both os/arch dependendent and not reproducible: it talks to https://pypi.org/simple/ (don't click on that link, it might freeze your browser) during extension evaluation.

@fmeum fmeum force-pushed the bazel-7.2.0 branch 2 times, most recently from 023c81d to 724a3df Compare May 29, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants