[WIP] [3/5] support C++20 Modules, add deps-scanner #22429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Rules-CPP
PikachuHyA
force-pushed
the
cxx20-modules-support-patch-3
branch
from
9582891
to
4f31b5a
Compare
PikachuHyA
force-pushed
the
cxx20-modules-support-patch-3
branch
from
4f31b5a
to
c6a1120
Compare
PikachuHyA
requested review from
a team,
oquenchil,
ahumesky and
ted-xie
as code owners
comius
requested review from
comius
and removed request for
lberki,
ahumesky,
ted-xie and
gregestren
comius
reviewed
May 22, 2024
src/main/java/com/google/devtools/build/lib/rules/cpp/CcModule.java
Outdated
Show resolved
Hide resolved
PikachuHyA
changed the title
PikachuHyA
force-pushed
the
cxx20-modules-support-patch-3
branch
from
c6a1120
to
546b0b7
Compare
|
I just keep the main commit in this patch. I also fix |
PikachuHyA
changed the title
sgowroji
added
awaiting-user-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split the XXL PR #19940 into several small patches.
This is the third patch of Support C++20 Modules, I add
deps-scannertool and update toolchainsUsing C++20 Modules means that compilation units must be compiled in topological order. see Discovering Dependencies.
Considering the various compilers, I add the tool
deps-scanner. The default implementation is a script wrapper that uses different scanning methods depending on the compiler. Here is a demo on how to scan C++20 dependencies. https://github.com/PikachuHyA/cpp20_modules_scan_dependency_demoI also update the toolchain, apply different flags to different actions.