Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GSON to 2.10.1 #22433

Closed
wants to merge 1 commit into from
Closed

Update GSON to 2.10.1 #22433

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 17, 2024

This adds support for record serialization.

Work towards #4005

@fmeum fmeum requested a review from Wyverald May 17, 2024 14:13
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 17, 2024
@Wyverald
Copy link
Member

Sorry, work towards what? I'll just assume that's a typo.

Also could you look at the test failures?

@fmeum
Copy link
Collaborator Author

fmeum commented May 17, 2024

Sorry, this was indeed a pretty heavy context switch. The reference is correct though: I'm in the process of reviewing #22427 and want to help the contributor use records for JSON (de-)serialization.

I updated the lockfile, which I hope will fix the tests.

This adds support for record serialization.

Work towards bazelbuild#4005
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 17, 2024
@keertk keertk added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label May 19, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 28, 2024
@fmeum fmeum deleted the gson branch May 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants