-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1029 - Form uploading screen #11629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoore108
changed the title
Wsteam1 1029 form uploading screen
WSTEAM1-1029 - Form uploading screen
May 16, 2024
karinathomasbbc
approved these changes
May 17, 2024
HarveyPeachey
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://jira.dev.bbc.co.uk/browse/WSTEAM1-1029
Overall changes
<Form />
component and out of the rootCode changes
<Uploading />
screen componentFormContext.Consumer
to get access to the context at the root of the page to allow screen switchingderivedHtmlType
logic as this is now determined in the BFFinitialScreen
prop for the root page to determine which screen to show initially. More so for Storybook benefitsTesting
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines