Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1029 - Form uploading screen #11629

Merged
merged 10 commits into from
May 20, 2024
Merged

Conversation

amoore108
Copy link
Contributor

@amoore108 amoore108 commented May 16, 2024

Part of https://jira.dev.bbc.co.uk/browse/WSTEAM1-1029

Overall changes

  • Adds 'Uploading' screen to UGC Form
  • Adds initial screen switching switch/case to allow state updates to change the displayed screen
  • Small change to background gradient to allow it to fill the entire screen regardless of form height
  • Moves Form header and description elements down into the <Form /> component and out of the root
  • Adds Storybook stories for the 2 current screens

Code changes

  • Adds <Uploading /> screen component
  • Exposes FormContext.Consumer to get access to the context at the root of the page to allow screen switching
  • Removes the derivedHtmlType logic as this is now determined in the BFF
  • Adds initialScreen prop for the root page to determine which screen to show initially. More so for Storybook benefits

Testing

  1. Visit https://wsteam1-1029-form-uploading-screen--5d28eb3fe163f6002046d6fa.chromatic.com/?path=/story/pages-ugc-page--uploading
  2. Confirm the layout meets UX and a11y requirements

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@amoore108 amoore108 self-assigned this May 16, 2024
@amoore108 amoore108 changed the title Wsteam1 1029 form uploading screen WSTEAM1-1029 - Form uploading screen May 16, 2024
@amoore108 amoore108 marked this pull request as ready for review May 16, 2024 14:28
@amoore108 amoore108 merged commit 0141e0d into latest May 20, 2024
11 checks passed
@amoore108 amoore108 deleted the WSTEAM1-1029-form-uploading-screen branch May 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants