Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1020 - Adds default styling for P and A elements on the Uploader form #11631

Merged

Conversation

HarveyPeachey
Copy link
Contributor

@HarveyPeachey HarveyPeachey commented May 17, 2024

Resolves JIRA WSTEAM1-1020

Overall changes

Adds default styling for p and a elements on the uploader page to fix a bug with Firefox retaining adjusted colours when disabled

Code changes

  • Refactors InlineLink component to export style object
  • Creates styles for p and a tags on Uploader components

Testing

  1. Cd into ws-nextjs-app
  2. Run yarn dev
  3. Visit http://localhost:7081/mundo/send/u50853472?renderer_env=live on Firfox
  4. Change colour settings in preferences
  5. See colour changes
  6. Set colours back to never
  7. Colours should revert back to default

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@HarveyPeachey HarveyPeachey self-assigned this May 20, 2024
@HarveyPeachey HarveyPeachey merged commit edaf647 into latest May 20, 2024
11 checks passed
@HarveyPeachey HarveyPeachey deleted the WSTEAM1-1020-adds-default-styling-text-link-uploader branch May 20, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants