New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix editor modal autofocus and autoresize #2214

Merged

rathboma merged 2 commits into master from fix/editor-modal-autofocus-autoresize

May 23, 2024

Contributor

azmy60 commented May 20, 2024 •

edited

It should auto focus the text editor when the editor modal is opened
It should resize the text editor in vertical automatically when the editor modal is opened
The modal stays in the same height as it was before closing it

Bug -> it changes the modal height when closing it for a split second:

Fix -> it should not do that really, cause it's kinda ugly.. 🤷

azmy60 added 2 commits

May 20, 2024 23:50


          fix editor modal autofocus and autoresize

316c33e


          keep editor modal height as it was before

46f963b

Contributor

ellipsis-dev bot commented May 20, 2024

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at help@ellipsis.dev

rathboma approved these changes

View reviewed changes

rathboma merged commit ab26569 into master

13 checks passed

rathboma deleted the fix/editor-modal-autofocus-autoresize branch

May 23, 2024 01:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment