Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix focus trap in modals #2215

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix focus trap in modals #2215

wants to merge 3 commits into from

Conversation

azmy60
Copy link
Contributor

@azmy60 azmy60 commented May 21, 2024

  • trap focus on all modals when they're opened.
  • an element inside a modal should be focused initially to make the focus trap work
  • some modals have a close button that can't be focused. Added href="#" to make them focusable.

Copy link
Contributor

ellipsis-dev bot commented May 21, 2024

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at help@ellipsis.dev

@rathboma
Copy link
Collaborator

@azmy60 merge conflict, then this is good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants