Permit Bigquery output to create jobs in a different project #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roviluca
force-pushed
the
main
branch
6 times, most recently
from
146c711
to
d9cc32b
Compare
Signed-off-by: luca.rovi <Roviluca@users.noreply.github.com> Signed-off-by: luca.rovinetti <luca.rovinetti@justeattakeaway.com>
|
Hello @Jeffail does this PR make sense or do you prefer me do approach this in another way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bigquery allows to have 3 different projects involved when querying Bigquery:
The current implementation does not allow this flexibility.
if the project is set the job will be created in the Dataset's project, otherwise the client tries to use
bigquery.DetectProjectIDthat returns the service account's project and searches the dataset in there.With this PR I added the possibility to set JobProjectID so that users can have the flexibility to set the 3 parameters with different values.