Nats Connection Pooling #2554
Open
Nats Connection Pooling #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a singleton pool to track connections being made to nats. Connections are tracked based on their Url + Nats Options, so defining different options will still result in multiple connections existing. However, nats components using the same url and nats options will reuse the connection. Signed-off-by: Daan Gerits <daan.gerits@gmail.com>
Signed-off-by: Daan Gerits <daan.gerits@gmail.com>
Signed-off-by: Daan Gerits <daan.gerits@gmail.com>
Signed-off-by: Daan Gerits <daan.gerits@gmail.com>
Signed-off-by: Daan Gerits <daan.gerits@gmail.com>
Signed-off-by: Daan Gerits <daan.gerits@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a singleton pool to track connections being made to nats.
Connections are tracked based on an advanced
pool_keyparameter. Components which share the same value for this parameter will also share the same connection.The pool will do reference tracking; for this each component has been equiped with a
pcidfield which holds a UUID upon instantiation. When a component retrieves a connection from the pool, itspicdis being added to the references. Components are required to release their connections and code has been adapted for them to do so. When releasing a connection, the reference will be removed from the connection and if no references are left, the connection will be closed and removed from the pool.