Additional kafka_franz input kafka consumer configuration
#2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendoxc
changed the title
kafka_franz input kafka consumer configuration
- `fetch_min_bytes` - `fetch_max_wait_ms` - `max_partition_fetch_bytes` - `max_poll_records` I've used the defaults, as what kafka defaults are Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
matches what franz go library expects when configuring a client Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
additionally removes `max_poll_records` as its not an available client option Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
this is the franz client's default Signed-off-by: hendoxc <hagen.henderson@smartcontract.com>
hendoxc
force-pushed
the
addititional-kafka-franz-consumer-configuration
branch
from
f5c819d
to
0a86319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding addition kafka configuration parameters that can be passed from
kafka_franzinput to the underlying franz client opts.the configurations added are:
Why
kafka_franzNotes
for
Default()I've used the defaults fromfranz-goclient opts as to not introduce new behaviour