Implement Color Operations for Color
#13285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bushrat011899
added
C-Enhancement
tychedelia
approved these changes
May 9, 2024
alice-i-cecile
approved these changes
May 9, 2024
alice-i-cecile
added
the
S-Ready-For-Final-Review
NthTensor
approved these changes
May 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@bushrat011899 you may need to tweak this to account for the removal of ClampColor. |
auto-merge was automatically disabled
May 13, 2024 23:57
Head branch was pushed to by a user without write access
bushrat011899
force-pushed
the
ColorOpsOnColor
branch
from
2d73b3c
to
c140f9f
Compare
Delegates to internal type when possible, otherwise uses `ChosenColorSpace` as an intermediary. This _will_ double convert, but this is considered an acceptable compromise since use of specific colour types in performance critical colour operations is already encouraged. `ChosenColorSpace` is `Oklcha` since it's perceptually uniform while supporting all required operations, and in my opinion is the "best" for this task. Using different spaces for different operations will make documenting this double-conversion behaviour more challenging. Call out explicitly why `Oklcha` is used for operations requiring conversion.
bushrat011899
force-pushed
the
ColorOpsOnColor
branch
from
c140f9f
to
f2e9c13
Compare
|
@alice-i-cecile should be good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Colortype #13214Solution
Delegates to internal type when possible, otherwise uses
ChosenColorSpaceas an intermediary. This will double convert, but this is considered an acceptable compromise since use of specific colour types in performance critical colour operations is already encouraged.ChosenColorSpaceisOklchasince it's perceptually uniform while supporting all required operations, and in my opinion is the "best" for this task. Using different spaces for different operations will make documenting this double-conversion behaviour more challenging.Testing
Changes straightforward enough to not require testing beyond current CI in my opinion.
Changelog
Color:LuminanceHueMixEuclideanDistanceClampColorColorexplaining the behaviour of these operations (possible conversion, etc.)