Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Scheduler paused forever #871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug: Scheduler paused forever #871

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2019

Environment

pyspider version: 0.3.10
oprate system version: ubuntu
launch command:pyspider -c config.json

I found if my project is paused, I can not recover my project while my project only product many on_cronjob tasks every n seconds.

My case:

Run on_start every 5 seconds.
After my project paused, my project active_tasks was filled by on_cronjob tasks.
My project _paused is "checking" forever.

@ghost ghost mentioned this pull request Feb 25, 2019
@ghost
Copy link
Author

ghost commented Feb 25, 2019

I have pushed PR.
Thank you very much.

@binux
Copy link
Owner

binux commented Mar 9, 2019

to unpause, the project have to have:

  1. at least UNPAUSE_CHECK_NUM task state respond with in last ACTIVE_TASKS.
  2. at least 1 process ok

selected tasks without respond is NOT considered as success tasks (as your code changes), which shouldn't unpause the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant