[bitnami/prometheus] Network policy review #25902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpfoster
force-pushed
the
prometheus-networkpolicy
branch
2 times, most recently
from
ec5bad1
to
c6ebca5
Compare
carrodher
added
verify
Apply the same changes made in PR bitnami#25519 to the Prometheus chart Signed-off-by: Ben Foster <bpfoster@gmail.com>
bpfoster
force-pushed
the
prometheus-networkpolicy
branch
from
c6ebca5
to
374aaec
Compare
Signed-off-by: Ben Foster <bpfoster@gmail.com>
Co-authored-by: Fran Mulero <francisco-jose.mulero@broadcom.com> Signed-off-by: Ben Foster <bpfoster@gmail.com>
|
Thanks @fmulero , merged in the latest |
Signed-off-by: Ben Foster <bpfoster@gmail.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
fmulero
added a commit
to fmulero/charts
that referenced
this pull request
May 22, 2024
* [bitnami/prometheus] Network policy review Apply the same changes made in PR bitnami#25519 to the Prometheus chart Signed-off-by: Ben Foster <bpfoster@gmail.com> * Apply suggestions from code review Co-authored-by: Fran Mulero <francisco-jose.mulero@broadcom.com> Signed-off-by: Ben Foster <bpfoster@gmail.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Fix Changelog Signed-off-by: Fran Mulero <fmulero@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> * Update CHANGELOG.md Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> --------- Signed-off-by: Ben Foster <bpfoster@gmail.com> Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com> Signed-off-by: Fran Mulero <fmulero@vmware.com> Co-authored-by: Fran Mulero <francisco-jose.mulero@broadcom.com> Co-authored-by: Bitnami Containers <bitnami-bot@vmware.com> Co-authored-by: Fran Mulero <fmulero@vmware.com> Signed-off-by: Fran Mulero <fmulero@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Apply the same changes made in PR #25519 to the Prometheus chart
Review network policy features to allow users cover their needs without forcing specific labels.
Benefits
Users can restrict access to their deployments in a cleaner way, without leaving open doors to specific labeled pods.
Possible drawbacks
None
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.README.mdusing readme-generator-for-helm