Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/grafana-tempo] Network policy review #25907

Merged
merged 2 commits into from
May 17, 2024

Conversation

bpfoster
Copy link
Contributor

Description of the change

Apply the same changes made in PR #25519 to the Tempo chart

Review network policy features to allow users cover their needs without forcing specific labels.

Benefits

Users can restrict access to their deployments in a cleaner way, without leaving open doors to specific labeled pods.

Possible drawbacks

None

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added grafana-tempo triage Triage is needed labels May 15, 2024
@github-actions github-actions bot requested a review from carrodher May 15, 2024 12:45
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels May 15, 2024
@github-actions github-actions bot removed the triage Triage is needed label May 15, 2024
@github-actions github-actions bot removed the request for review from carrodher May 15, 2024 14:06
@github-actions github-actions bot requested a review from migruiz4 May 15, 2024 14:06
Apply the same changes made in PR bitnami#25519 to the Tempo chart

Signed-off-by: Ben Foster <bpfoster@gmail.com>
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
Copy link
Member

@migruiz4 migruiz4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@migruiz4 migruiz4 enabled auto-merge (squash) May 17, 2024 11:48
@migruiz4 migruiz4 merged commit 4e3d87c into bitnami:main May 17, 2024
9 checks passed
@bpfoster bpfoster deleted the tempo-networkpolicy branch May 17, 2024 13:00
fmulero pushed a commit to fmulero/charts that referenced this pull request May 22, 2024
Apply the same changes made in PR bitnami#25519 to the Tempo chart

Signed-off-by: Ben Foster <bpfoster@gmail.com>
Signed-off-by: Miguel Ruiz <miruiz@vmware.com>
Co-authored-by: Miguel Ruiz <miruiz@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grafana-tempo solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants