Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/etcd] Revert #25896 #25917

Merged
merged 4 commits into from
May 17, 2024
Merged

[bitnami/etcd] Revert #25896 #25917

merged 4 commits into from
May 17, 2024

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented May 15, 2024

Description of the change

This reverts #25896

Benefits

Conditions added in that PR are not needed.

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@fmulero
[bitnami/etcd] PDB review
b572262 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero
[bitnami/etcd] Revert previous changes in PDB
1d0861a 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero
Merge remote-tracking branch 'upstream/main' into bugfix/etcd-pdb
43c569d 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero
Re-apply changes
97fa1e9 
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero fmulero enabled auto-merge (squash) May 15, 2024 14:51
@github-actions github-actions bot added the etcd label May 15, 2024
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label May 15, 2024
@github-actions github-actions bot requested a review from jotamartos May 15, 2024 14:52
@fmulero fmulero merged commit 8f095b1 into bitnami:main May 17, 2024
17 checks passed
fmulero added a commit to fmulero/charts that referenced this pull request May 22, 2024
@fmulero
[bitnami/etcd] Revert bitnami#25896 (bitnami#25917)
635e505 
* [bitnami/etcd] PDB review

Signed-off-by: Fran Mulero <fmulero@vmware.com>

* [bitnami/etcd] Revert previous changes in PDB

Signed-off-by: Fran Mulero <fmulero@vmware.com>

* Re-apply changes

Signed-off-by: Fran Mulero <fmulero@vmware.com>

---------

Signed-off-by: Fran Mulero <fmulero@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotamartos jotamartos jotamartos approved these changes

Assignees

@jotamartos jotamartos

Labels
bitnami etcd solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmulero @jotamartos @bitnami-bot