New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/kafka] PDB review #25938

Merged

dgomezleon merged 18 commits into bitnami:main from fmulero:bugfix/kafka-pdb

May 29, 2024

Collaborator

fmulero commented May 15, 2024 •

edited

Description of the change

Little fixes in PodDisruptionBudget configuration to keep it aligned with current templates. Also some other changes were applied related to autoscaling.

Benefits

Keep our charts up to date according to our templates

Possible drawbacks

None

Adition information

Checklist

Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
All commits signed off and in agreement of Developer Certificate of Origin (DCO)


          [bitnami/kafka] PDB review

c34aad9

Signed-off-by: Fran Mulero <fmulero@vmware.com>

fmulero enabled auto-merge (squash)

May 15, 2024 16:29

github-actions bot added the kafka label

bitnami-bot added the verify label

github-actions bot added the bitnami label

github-actions bot assigned dgomezleon

github-actions bot requested a review from dgomezleon

May 15, 2024 16:29


          Merge branch 'main' into bugfix/kafka-pdb

f0ffdcd

Signed-off-by: Carlos Rodríguez Hernández <carlosrh@vmware.com>

fmulero disabled auto-merge

May 20, 2024 16:57

fmulero and others added 14 commits

May 21, 2024 09:38


          pdb.create enabled by default

d83702c

Signed-off-by: Fran Mulero <fmulero@vmware.com>


          Update README.md with readme-generator-for-helm

013a8b2

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>


          Merge remote-tracking branch 'upstream/main' into bugfix/kafka-pdb

e35ef07


          Update CHANGELOG.md

bd4ae7d

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>


          Merge remote-tracking branch 'upstream/main' into bugfix/kafka-pdb

aae1734


          Set maxUnavailable on PodDisruptionBudgent when pdb.minAvailable and …

2e73a08

…pdb.maxUnavailable are empty

Signed-off-by: Fran Mulero <fmulero@vmware.com>


          Update CHANGELOG.md

e6422e3

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>


          Update README.md with readme-generator-for-helm

66afe24

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>


          Merge remote-tracking branch 'upstream/main' into bugfix/kafka-pdb

08fcd97

Signed-off-by: Fran Mulero <fmulero@vmware.com>


          Update CHANGELOG.md

d18a94e

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>


          Merge branch 'main' into bugfix/kafka-pdb

0130cc7

Signed-off-by: Fran Mulero <fmulero@vmware.com>


          Update CHANGELOG.md

ccb9144

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>


          Merge remote-tracking branch 'upstream/main' into bugfix/kafka-pdb

fca1026


          Remove metrics PDB

a88cccb

Signed-off-by: Fran Mulero <fmulero@vmware.com>

dgomezleon requested changes

View reviewed changes

Member

dgomezleon left a comment

Please, use a patch bump for the version.


          Bump patch version

2d2d5c3

Signed-off-by: Fran Mulero <fmulero@vmware.com>

dgomezleon previously approved these changes

View reviewed changes

Member

dgomezleon left a comment

LGTM


          Update README.md with readme-generator-for-helm

81471bd

Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>

bitnami-bot dismissed dgomezleon’s stale review via

81471bd

May 29, 2024 10:23

dgomezleon approved these changes

View reviewed changes

dgomezleon enabled auto-merge (squash)

May 29, 2024 10:29

dgomezleon merged commit 568aafa into bitnami:main

10 checks passed

github-actions bot added the solved label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment