Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/mysql] Add a warning on running older versions of MySQL #25947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fabiocarneiro
Copy link

Description of the change

Add a warning on the README section that explains that the chart is only tested with MySQL 8.x and will most likely not work with older versions.

Benefits

People will not waste time trying to run with older images or at least be aware that there is some additional research to be made on the differences and potential other changes required.

Possible drawbacks

None

Applicable issues

Checklist

Signed-off-by: Fábio Carneiro <fahecs@gmail.com>
@github-actions github-actions bot added mysql triage Triage is needed labels May 16, 2024
@github-actions github-actions bot requested a review from javsalgar May 16, 2024 11:54
Copy link
Member

@carrodher carrodher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.

Comment on lines +59 to +63
### Use a different MySQL 8.x version

To modify the application version used in this chart, specify a different version of the image using the `image.tag` parameter and/or a different repository using the `image.repository` parameter.

> **Warning**: This chart is tested with MySQL version 8.x. Older versions most likely won't work if you merely switch the tag.
Copy link
Member

@carrodher carrodher May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Use a different MySQL 8.x version
To modify the application version used in this chart, specify a different version of the image using the `image.tag` parameter and/or a different repository using the `image.repository` parameter.
> **Warning**: This chart is tested with MySQL version 8.x. Older versions most likely won't work if you merely switch the tag.
### Use a different MySQL version
To modify the application version used in this chart, specify a different version of the image using the `image.tag` parameter and/or a different repository using the `image.repository` parameter.
> **Warning**: Each bitnami/mysql Helm chart is created using a specific MySQL version which is tested in our automated test & release pipeline. Substituting the version could cause degraded performance, broken chart features, or missing environment variables.

I would opt for a more generic wording not only about 8.x

Copy link

github-actions bot commented Jun 1, 2024

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mysql stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the chart mysql working with mysql 5.7 version
3 participants