-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-1937] Server: Implement endpoint to retrieve provider payment information #4093
Conversation
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
New Issues
|
} | ||
|
||
var taxInformation = await paymentService.GetTaxInfoAsync(provider); | ||
var billingInformation = await paymentService.GetBillingAsync(provider); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetBillingAsync
is the method we discussed in our Dev Sync that we determined does a little too much work for what's asked of it. We'd also like to try and phase out the StripePaymentService
as much as possible. What do you think about adding two new methods to the SubscriberService
?
SubscriberService.GetTaxInformation
and SubscriberService.GetPaymentMethod
. You could add new DTOs representing tax information and a payment method in our Core/Billing folder so we'd have ownership of them. Then, the ProviderPaymentInfoDTO
could use those two new DTOs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry might have missed something, but I think I got pinged for a re-review. Did we have an update here?
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
…lement-endpoint-to-retrieve-provider-payment-information
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
bfc1fbf
to
f0ce176
Compare
c0dfd57
to
f0ce176
Compare
Type of change
Objective
Implement an Admin Console endpoint that retrieves a provider’s payment information. This endpoint should only be accessible to the ProviderAdmin.
Data Required
How much account credit the provider has
The provider’s truncated payment method information
Card type
Last 4
Expiration MM/YYYY
The provider’s tax information (same as paid organizations)
Code changes
Before you submit
dotnet format --verify-no-changes
) (required)