[SM-1256] Add BulkSecretAuthorizationHandler #4099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4099 +/- ##
==========================================
+ Coverage 39.31% 39.34% +0.03%
==========================================
Files 1201 1203 +2
Lines 57994 58030 +36
Branches 5336 5338 +2
==========================================
+ Hits 22799 22832 +33
- Misses 34139 34142 +3
Partials 1056 1056 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
coltonhurst
reviewed
May 22, 2024
| _ => secrets.Select(s => new SecretAccess(s.Id, false, false)) | ||
| }; | ||
|
|
||
| private record SecretAccess(Guid Id, bool Read, bool Write); |
There was a problem hiding this comment.
Nit: Any reason this is at the bottom of the file instead of the top? There are a few other records we have in the middle of files, I'm used to type defs and fields at the top of a file or class. No big deal though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The purpose of this PR is to add a
BulkSecretAuthorizationHandlerand use it for theGetSecretsByIdsAsyncendpoint.Code changes
file.ext: Description of what was changed and why
bitwarden_license/src/Commercial.Core/SecretsManager/AuthorizationHandlers/Secrets/BulkSecretAuthorizationHandler.cs:
src/Core/SecretsManager/AuthorizationRequirements/BulkSecretOperationRequirement.cs:
Add new bulk authz handler.
bitwarden_license/src/Commercial.Core/SecretsManager/SecretsManagerCollectionExtensions.cs:
Add handler to DI.
bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/SecretRepository.cs:
src/Core/SecretsManager/Repositories/ISecretRepository.cs:
src/Core/SecretsManager/Repositories/Noop/NoopSecretRepository.cs:
Add
AccessToSecretsAsyncto the repository.bitwarden_license/test/Commercial.Core.Test/SecretsManager/AuthorizationHandlers/Secrets/BulkSecretAuthorizationHandlerTests.cs:
Add authz handler unit tests.
src/Api/SecretsManager/Controllers/SecretsController.cs:
Use the new bulk authz handler for the
GetSecretsByIdsAsyncendpoint.test/Api.Test/SecretsManager/Controllers/SecretsControllerTests.cs:
Update unit tests
Before you submit
dotnet format --verify-no-changes) (required)