Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth! #11347

Merged
merged 35 commits into from
May 18, 2024
Merged

Auth! #11347

merged 35 commits into from
May 18, 2024

Conversation

blakeblackshear
Copy link
Owner

@blakeblackshear blakeblackshear commented May 12, 2024 •
edited

Todos:

  • bypass for exports/audio and trusted networks
  • auth settings in home assistant integration
  • update docs
  • consider splitting salt between db and config file
  • add profile endpoint to api to return user
    • look for ways to make things compatible with upstream proxies (traefik-forward-auth, authelia, oauth2_proxy, home assistant addon). add logout url/endpoint for upstream auth
  • implement logout
  • fix bug in db call on refresh jwt
  • login screen not bringing up keyboard when installed as app in ios

@netlify Netlify
Copy link

netlify bot commented May 12, 2024 •
edited

✅ Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 20b9a85
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6648d6df2707d10008d97000
😎 Deploy Preview https://deploy-preview-11347--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 12, 2024
View reviewed changes
frigate/api/auth.py Dismissed Show dismissed Hide dismissed
frigate/app.py Dismissed Show dismissed Hide dismissed
frigate/app.py Dismissed Show dismissed Hide dismissed
frigate/api/auth.py Dismissed Show dismissed Hide dismissed
frigate/api/auth.py Dismissed Show dismissed Hide dismissed
@NickM-27 NickM-27 linked an issue May 12, 2024 that may be closed by this pull request
[FR] Authentication! #1074
Closed
NickM-27
NickM-27 reviewed May 12, 2024
View reviewed changes
web/src/LoginPage.tsx Outdated Show resolved Hide resolved
web/src/components/AuthForm.tsx Outdated Show resolved Hide resolved
NickM-27
NickM-27 reviewed May 12, 2024
View reviewed changes
frigate/config.py Outdated Show resolved Hide resolved
@freefd freefd mentioned this pull request May 13, 2024
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 15, 2024
View reviewed changes
frigate/api/auth.py Dismissed Show dismissed Hide dismissed
frigate/api/auth.py Dismissed Show dismissed Hide dismissed
frigate/api/auth.py Dismissed Show dismissed Hide dismissed
frigate/api/auth.py Dismissed Show dismissed Hide dismissed
@blakeblackshear
reload the window on 401
c708953
@blakeblackshear
backend apis for auth
fca9281
@blakeblackshear
add login page
0f658c6
@blakeblackshear
re-enable web linter
0f6c430
@blakeblackshear
fix login page routing
5acee64
@blakeblackshear
bypass csrf for internal auth endpoint
fa34e4d
@blakeblackshear
disable healthcheck in devcontainer target
7094560
@blakeblackshear
include login page in vite build
8310063
@blakeblackshear
redirect to login page on 401
5962a24
@blakeblackshear
implement config for users and settings
38f2554
@blakeblackshear
implement JWT actual secret
bf35d16
@blakeblackshear
add brute force protection on login
115d2bc
@blakeblackshear
add support for redirecting from auth failures on api calls
46cbe98
@blakeblackshear
return location for redirect
952df23
@blakeblackshear
default cookie name should pass regex test
aa1d02d
@blakeblackshear
set hash iterations to current OWASP recommendation
7cf3abc
@blakeblackshear
move users to database instead of config
fafc0aa
@blakeblackshear
config option to reset admin password on startup
d6b517d
@blakeblackshear
user management UI
58ae223
@blakeblackshear
check for deleted user on refresh
1284704
@blakeblackshear blakeblackshear marked this pull request as ready for review May 18, 2024 15:52
NickM-27
NickM-27 requested changes May 18, 2024
View reviewed changes
docs/docs/configuration/authentication.md Outdated Show resolved Hide resolved
docs/docs/configuration/authentication.md Outdated Show resolved Hide resolved
blakeblackshear and others added 2 commits May 18, 2024 11:26
@blakeblackshear @NickM-27
Update docs/docs/configuration/authentication.md
eacf790 
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
@blakeblackshear @NickM-27
Update docs/docs/configuration/authentication.md
20b9a85 
Co-authored-by: Nicolas Mowen <nickmowen213@gmail.com>
@NickM-27 NickM-27 merged commit 1133202 into dev May 18, 2024
13 checks passed
@NickM-27 NickM-27 deleted the auth branch May 18, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickM-27 NickM-27 NickM-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Authentication!
2 participants
@blakeblackshear @NickM-27