Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gearbox #709

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Gearbox #709

wants to merge 12 commits into from

Conversation

qshao-gauntlet
Copy link
Collaborator

What?

ie: Add support for uniswap contract events

How?

ie: I used abi-parser or cli tools to build the table definitions

Related PRs (optional)

PRs that are related to this or may need to be deployed before this PR

Anything Else?

Copy link
Collaborator

@kome12 kome12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI/CD is currently failing because some of the name field has an empty string. Can you please add the name field?

{
"indexed": true,
"internalType": "address",
"name": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a name for this field.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed these

"schema": [
{
"description": "",
"name": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a name for this field.

{
"indexed": true,
"internalType": "address",
"name": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a name for this field.

"schema": [
{
"description": "",
"name": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a name for this field.

{
"indexed": true,
"internalType": "address",
"name": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a name for this field.

"schema": [
{
"description": "",
"name": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to add a name for this field.

@zigzag2002
Copy link
Contributor

The CI/CD is currently failing because some of the name field has an empty string. Can you please add the name field?

Added names for all events, please approve when you get the chance to look over the changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants