Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #309 cannot get block ranges for dates on arbitrum #342

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sfsf9797
Copy link
Contributor

@sfsf9797 sfsf9797 commented May 4, 2022

@sfsf9797 sfsf9797 changed the title handle case when blocks have same timestamp fix for #309 cannot get block ranges for dates on arbitrum May 4, 2022
@jensenity
Copy link

jensenity commented Aug 27, 2023

hi @medvedev1088, I'm also facing the same problem rn running optimism etl but getting the same coordinate in y...

File "/usr/local/lib/python3.8/site-packages/ethereumetl/service/graph_operations.py", line 87, in _get_bounds_for_y_coordinate_recursive
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -     return self._get_bounds_for_y_coordinate_recursive(y, *bounds)
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -   File "/usr/local/lib/python3.8/site-packages/ethereumetl/service/graph_operations.py", line 87, in _get_bounds_for_y_coordinate_recursive
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -     return self._get_bounds_for_y_coordinate_recursive(y, *bounds)
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -   File "/usr/local/lib/python3.8/site-packages/ethereumetl/service/graph_operations.py", line 87, in _get_bounds_for_y_coordinate_recursive
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -     return self._get_bounds_for_y_coordinate_recursive(y, *bounds)
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -   File "/usr/local/lib/python3.8/site-packages/ethereumetl/service/graph_operations.py", line 77, in _get_bounds_for_y_coordinate_recursive
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -     estimation2_x = interpolate(*points, y)
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -   File "/usr/local/lib/python3.8/site-packages/ethereumetl/service/graph_operations.py", line 117, in interpolate
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO -     raise ValueError('The y coordinate for points is the same {}, {}'.format(point1, point2))
[2023-08-26, 16:44:00 UTC] {pod_manager.py:367} INFO - ValueError: The y coordinate for points is the same (136,1636667979), (137,1636667979)

@sfsf9797
Copy link
Contributor Author

Ya it happens when the coordinates has same value for Y, should be a simple fix. Cc @allenday too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants