Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/kafka transactions #370

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

FeSens
Copy link
Contributor

@FeSens FeSens commented Jul 16, 2022

Extents Pull #369, inserting data in Kafka through transactions for improved reliability.
Changes the dependency from 'kafka-python==2.0.2', to 'confluent-kafka==1.9.0', since the first do not support transactions.

Fix the error type in the KafkaItemExporter.get_connection_url form KeyError to IndexError, since the error for lists are IndexErro's and for dictionaries are KeyError's.. And the function is dealing with a list.

@FeSens
Copy link
Contributor Author

FeSens commented Jul 16, 2022

@medvedev1088, @ayush3298, can you give it a look, please =)

@medvedev1088
Copy link
Member

@beyondblog @ayush3298 do you mind taking a look please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants