Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build mechanism #114

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Build mechanism #114

wants to merge 4 commits into from

Conversation

mcgr0g
Copy link

@mcgr0g mcgr0g commented Dec 21, 2022

brought several improvements:

  • the ability to use dev containers on Windows VS Code
  • using a multi-stage build to reduce the size of the final image
  • more secure installation of poetry, as recommended by the developers
  • no pip usage
  • venv transport between images for painless and easy app installation in both debian-slim and alpine
  • custom build scripts revised and moved to makefile instructions
  • added commands to calculate image size
  • revised and moved commands for multiarch build. With context cleanup after completion.
  • added instructions for smoke testing the built image
  • significant details are reflected in the readme
  • following the OCI Image Format Specification

@bluet
Copy link
Owner

bluet commented Dec 30, 2022

hi @mcgr0g thanks for the big patch. I might need some time to review it. lol

@hms5232 @ziloka @afunTW @vincentinttsh would you like to take a look?

@hms5232
Copy link

hms5232 commented Dec 31, 2022

I notice the develop environment setting set Poetry version 1.3.1, but project pipeline current is 1.1.4. I had made a PR to bump Poetry version in action test (see #115 ).

@afunTW
Copy link
Collaborator

afunTW commented Dec 31, 2022

Personally, I prefer to keep the repo natural which means any setting for a specific IDE should be set in .gitignore. Let the developer focus on features and bugfix.

Or, from another viewpoint, aligning the development setting can boost the community's efficiency.

So far, seems the community go on the second option. As long as the testing passed, I am ok with that.

@sonarcloud
Copy link

sonarcloud bot commented Dec 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vincentinttsh
Copy link
Collaborator

I have same thought as afunTW

@ziloka
Copy link

ziloka commented Feb 12, 2023

aligning the development setting can boost the community's efficiency.

I agree

@ziloka
Copy link

ziloka commented Feb 13, 2023

However after digging through python a bit more (I'm not an experienced python developer).

I found it that devcontainers are a bit heavy, and requires developers to install docker.

A easier solution is to create a virtual environment via poetry

poetry env use python

However I do agree using devcontainers give all developers a easier reproducible environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants