Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box_select not working as active_drag for gridplot #8766

Closed
tony-bony opened this issue Mar 18, 2019 · 3 comments · Fixed by #13888
Closed

box_select not working as active_drag for gridplot #8766

tony-bony opened this issue Mar 18, 2019 · 3 comments · Fixed by #13888
Labels
reso: completed tag: component: bokehjs type: bug
Milestone
3.5

Comments

@tony-bony
Copy link

ALL software version info (bokeh, python, notebook, OS, browser, any other relevant packages)

Python version      :  2.7.15 (default, Oct  4 2018, 22:42:40) 
IPython version     :  5.8.0
Tornado version     :  4.5.3
Bokeh version       :  1.0.4
BokehJS static path :  /usr/local/lib/python2.7/site-packages/bokeh/server/static
node.js version     :  v10.15.1
npm version         :  6.7.0

OS: Mac OS X Yosemite 10.10.5
Browser: Google Chrome 72.0.3626.121 (Official Build) (64-bit)

Description of expected behavior and the observed behavior
The box_select should be the active drag tool in the gridplot's toolbar. Now it looks like always the first drag tool is being active (PanTool in example below)

Complete, minimal, self-contained example code that reproduces the issue

from bokeh.plotting import figure, show
from bokeh.layouts import gridplot

plots = [figure(active_drag = 'box_select', tools = 'pan,wheel_zoom,box_zoom,reset,tap,crosshair,save,box_select') for i in range(6)]
show(gridplot(children = plots, ncols = 3, merge_tools = True))
@mattpap mattpap added this to the short-term milestone Mar 19, 2019
@evoulitas
Copy link

Hello, is there some information on when this issue will be fixed please?
It seems that gridplot is the only way to have merged tools (vs column for example), but it is impossible to set the active ones (while in a column this is feasible).

@bryevdv
Copy link
Member

bryevdv commented Mar 12, 2021 •
edited

@evoulitas Bokeh is a volunteer OSS project and contributors self-direct their own work. If no-one has added it to a concrete milestone then I would not count on it being looked at at any particular time.

@philippjfr
Copy link
Contributor

@mattpap This would be really nice to have. Part of the problem is that there isn't even a workaround, since merging the tools creates ToolProxy objects and the active_ properties don't allow for ToolProxy types. Either we should allow ToolProxy objects on the active_ properties or it should internally check if the active_<gesture> refers to one of the tools owned by the ToolProxy.

@philippjfr philippjfr mentioned this issue May 7, 2024
Open
@mattpap mattpap modified the milestones: short-term, 3.5 May 7, 2024
@mattpap mattpap mentioned this issue May 9, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
reso: completed tag: component: bokehjs type: bug
Projects
None yet
Milestone
3.5
Development

Successfully merging a pull request may close this issue.

Robustify activation of tools/proxies in merged toolbars bokeh/bokeh
5 participants
@mattpap @bryevdv @philippjfr @evoulitas @tony-bony