Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify activation of tools/proxies in merged toolbars #13888

Merged
merged 2 commits into from
May 30, 2024

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented May 9, 2024

This PR:

  • fixes handling of active_ properties when merging toolbars
  • allows to use ToolProxy in active_ properties
  • allows to activate a proxy with a single tool that belongs to that proxy
Screencast.from.09.05.2024.12.55.00.webm
Code
from bokeh.plotting import figure, show
from bokeh.layouts import gridplot

tools = "pan,wheel_zoom,box_zoom,reset,tap,crosshair,save,box_select"
plots = [figure(active_drag="box_select", tools=tools, width=200, height=200) for _ in range(2)]
for p in plots:
    p.scatter([1, 2, 3], [1, 2, 3], size=10)
gp = gridplot(children=plots, ncols=3, merge_tools=True)
show(gp)

fixes #8766

@mattpap mattpap added this to the 3.5 milestone May 9, 2024
Copy link
Contributor

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mattpap mattpap force-pushed the mattpap/8766_active_tool_proxy branch from d55bcc7 to 1256a6e Compare May 30, 2024 09:33
@mattpap mattpap merged commit efeff1f into branch-3.5 May 30, 2024
23 of 25 checks passed
@mattpap mattpap deleted the mattpap/8766_active_tool_proxy branch May 30, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

box_select not working as active_drag for gridplot
2 participants