Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for basic measurement tools #13279

Open
wants to merge 1 commit into
base: branch-3.5
Choose a base branch
from

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Jul 24, 2023

Very early prototype. The main goals of this PR are the following:

  1. Establish a set of "scalar" glyphs (called shapes), that will be useful as basic building blocks of more complex visuals, but without the heaviness of glyphs and legacy cruft of annotations.
  2. Establish a more flexible way of specifying coordinates while migrating to use sub-coordinates (e.g. no x_units etc. anymore).

Measurement tools in this PR are a side effect and a practical way of showing those working.

fixes #182

Example:
image

@mattpap mattpap added this to the 3.3 milestone Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (69bddb5) to head (276c4d0).
Report is 1 commits behind head on branch-3.5.

❗ Current head 276c4d0 differs from pull request most recent head 9c98436. Consider uploading reports for the commit 9c98436 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.5   #13279      +/-   ##
==============================================
- Coverage       92.65%   92.63%   -0.02%     
==============================================
  Files             326      323       -3     
  Lines           20736    20640      -96     
==============================================
- Hits            19212    19120      -92     
+ Misses           1524     1520       -4     

@jbednar
Copy link
Contributor

jbednar commented Jul 24, 2023

Fixes issue #182, opened ten years ago!!!

image

@mattpap mattpap modified the milestones: 3.3, 3.4 Oct 4, 2023
@mattpap mattpap changed the base branch from branch-3.3 to branch-3.4 October 10, 2023 12:46
@mattpap mattpap force-pushed the mattpap/182_measurement_tools branch from 41251e3 to dc840ef Compare October 15, 2023 09:01
@mattpap mattpap force-pushed the mattpap/182_measurement_tools branch from dc840ef to 60d259c Compare November 18, 2023 01:13
@mattpap mattpap force-pushed the mattpap/182_measurement_tools branch 4 times, most recently from acd8260 to 276c4d0 Compare December 6, 2023 20:12
@mattpap mattpap modified the milestones: 3.4, 3.5 Feb 28, 2024
@mattpap mattpap changed the base branch from branch-3.4 to branch-3.5 March 14, 2024 16:54
@mattpap mattpap force-pushed the mattpap/182_measurement_tools branch from 276c4d0 to cd63514 Compare April 9, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

measurement tools
2 participants