Make GlyphView.mask_data()
always narrow indices to the viewport
#13332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
mask_data()
usually returned all (subset) indices and only give non-trivial results for a handful of glyphs. This PR makesmask_data()
always narrow indices to view viewport (and utilize the spatial index). There's a handful of glyphs that require special behavior, because e.g. their_render()
method doesn't work will with non-contiguous indices. This is in preparation to fix point (1) from holoviz/holoviews#5840 (comment).