-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhanced the default datetimeformatter with a dynamic one #13854
base: branch-3.5
Are you sure you want to change the base?
enhanced the default datetimeformatter with a dynamic one #13854
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13854 +/- ##
==============================================
+ Coverage 91.57% 92.64% +1.06%
==============================================
Files 326 326
Lines 20737 20765 +28
==============================================
+ Hits 18990 19237 +247
+ Misses 1747 1528 -219 |
Unfortunately, this will take more work / different approach. The issue is that the way things are done in the PR, every single axis has a different An immediate solution could be get rid of Or perhaps |
@bryevdv Thanks for pointing out the sided effects. However I am wondering if there have been similar cases in the past or is this the first one? |
It's not common to have dynamic defaults, less common still have to have dynamic defaults that are model instances, and among that tiny set, I do believe this would be the first time ever a dynamic instance default itself had property that was also such. I think you should try building without |
@bryevdv Building without InstanceDefault works out fine. When building the docs there aren't any rendering issues but of course the static (and therefore wrong) default values are shown. |
All pull requests must have an associated issue in the issue tracker. If there
isn't one, please go open an issue describing the defect, deficiency or desired
feature. You can read more about our issue and PR processes in the
wiki.