Contain all rendering related tasks in DOMView.render()
#13871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rendering is spread in multiple places, including
initialize()
,connect_signals()
andrender()
. When re-renderingthis.el
(the root element of a component) never gets recreated. It's "emptied" instead, but that doesn't really clear all the associated state with that element, which can cause issues when callingrender()
multiple times.This PR moves all rendering related tasks to
render()
method, including creation ofthis.el
. If re-rendering, thenrender()
will create a new DOM element and then usereplaceWith
to efficiently replace it in the existing DOM hierarchy. This makes re-rendering much more predictable. Re-rendering, especially unnecessary re-rendering, is not advised, but sometimes necessary.